On Fri, Jun 19, 2009 at 10:00:41AM -0700, Alan Irwin wrote: > On 2009-06-19 06:35+0300 Dmitri Gribenko wrote: > > > Use QMutexLocker in Qt driver. RAII is always better than managing > > resources by hand. > > Hi Dmitri: > > This patch has been reviewed and approved by Alban, but not tested by him. > My light testing (make test_noninteractive in the installed examples tree) > showed no obvious issues. Therefore, I have committed this patch (revision > 10055). > > Thanks! > > Hi Andrew: > > I have addressed this post to you as well because the previous commit > message that put in a mutex for this device implied you had a thread safety > test for the qt device at that time: > > ******** > r9765 | airwin | 2009-03-21 08:39:08 -0700 (Sat, 21 Mar 2009) | 8 lines > > AWI for Alban Rochel. > > - Introduce a mutex to make driver thread safe. > > Andrew noticed that when 2 qtwidgets were running on 2 streams, closing them > didn't close the driver properly. This issue should be fixed by this change. > ******** > > Could you apply the same test for this new way of handling the qt mutex? > Also, if you could share the details of your test (i.e., what example to run > interactively and how to identify when the driver is not closed properly), I > should be able to incorporate it into our interactive test suite so that > anybody could run the test on any platform.
Alan, The original test just involved running the multiple stream example 14 with two devices, one interactive and one file based. Originally there were global variables set which depended on the type of the first initialised device. I think problems occured if you initialised the file based driver first then tried to use an interactive driver for the second stream. I would have to check though. Andrew ------------------------------------------------------------------------------ Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. Need another reason to go? 24-hour hacker lounge. Register today! http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
