cpd73 wrote: 
> The problem is, I use none of this so have no idea how/if it works (as
> in Material's usage of). So, -should- I use include_online_artists:1
> with role_id:ALBUMARTIST for the album artists, or *only* when no
> role_id is specified? Please don't say its up to me, as (as stated) I
> dont use this - so really don't know what it -should- be. My -guess- is
> that it should be used in the "Artists", "All Artists", and "Album
> Artists" lists, but not elsewhere. Would that be correct? i.e. use if no
> rol_id, or rol_id:ALBUMARTIST

Ok, you're close. Here's the only place where LMS is using the
include_online_only_artists flag:


Code:
--------------------
        # only get external artists without album if no filter is set
        my $queryTags = 'Es';
        if ( ($library_id && $library_id ne 
(Slim::Music::VirtualLibraries->getLibraryIdForClient($client) || ''))
                || ($search && !scalar grep { $_ !~ /^library_id:/} @searchTags)
                || (scalar grep { $_ !~ /^role_id:.*ALBUMARTIST|^library_id:/} 
@searchTags)
        ) {
                $queryTags = 's';
        }
        else {
                push @searchTags, 'include_online_only_artists:1'
        }
  
--------------------


https://github.com/Logitech/slimserver/blob/e2f699cbc7fa06988bd3321c725ac8bb478ff06f/Slim/Menu/BrowseLibrary.pm#L1090

Which I read pretty much like what the comment says. Do NOT include
"online only artists" if:
    
- a library_id is defined, and it's not the player's default library
- there is a search term
- there is a filter criteria other than role_id:ALBUMARTIST
  

So contrary to what I thought your guess was right: we would show that
list on an album artists list, assuming that all artists "liked" on a
streaming service would also be an album artist.



Michael

"It doesn't work - what shall I do?" - "Please check your server.log
and/or scanner.log file!"
(LMS: Settings/Information)
------------------------------------------------------------------------
mherger's Profile: http://forums.slimdevices.com/member.php?userid=50
View this thread: http://forums.slimdevices.com/showthread.php?t=109624

_______________________________________________
plugins mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/plugins

Reply via email to