PasTim wrote: > I think bpa alterted him, but I don't know what if anything happened > then. I guess most people are on 7.7. to 7.9 version and might want the > update.
mherger wrote: > > Does anyone know whether Michael has incorporated the modded the > Windows > > faad.exe into the nightlies? > > No, I haven't. I don't want to break things at this point, as I won't be > > able to fix anything for a few weeks. I asked the person who got in > touch with me to thoroughly test his build. If this is running fine for > > you, then it should be easy for me to include it in the builds when I'm > > ready for it. > > -- > > Michael As Michael said, we need to test this fix as widely as possible for him to be confident to include this, given that the existing build has remained unchanged for several years. So it would be appreciated if folks, particularly with unusual windows configurations (I've only got win7), can confirm this is ok - ideally checking that other aac transcoding is ok, including seeking (e.g. if you've got iTunes .m4a files, etc.). There are actually two things to ascertain here - is my source fix ok, and have I build the .exe correctly. On the first point, the fix I've listed here: '#3614' (http://forums.slimdevices.com/showthread.php?53229-Announce-BBCiPlayer-Plugin-(UK-only)&p=813434&viewfull=1#post813434), (and done the build for) I'm pretty confident is the right thing. The fix given isn't windows specific, and should be fine and appropriate for non-windows builds, even though it doesn't appear to be necessary - at least for the one arm linux system I've looked at and from the evidence of others here. But I suppose that to make absolutely sure of that we'd need to thoroughly test all non-windows versions, which increases the scope hugely. So below I've recoded the fix so that it only applies to windows. On the second point, I've done the build using Visual Studio, as this is what bpa said the original was built with - albeit that I've used VS 2010 (on 32-bit win7) and the previous build is so old it may have used a previous version. The sources in github here: https://github.com/Logitech/slimserver-vendor/tree/public/7.9/faad2 have a Visual Studio project file, but this is the vanilla faad2-2.7 one and needs a bit of tweaking to build the special squeezebox version. So it looks like Andy Grundman did a build using a local VS project file that isn't recorded anywhere. The long-and-short-of-it is that I can't be 100% sure that the .exe I've built is as compatible across all windows versions as the one Andy built - that's why we need some testing! The revised code (which produces an identical windows .exe to that which I already posted, but is unchanged for non-windows builds) is now: Code: -------------------- #ifdef _WIN32 if (0 == strcmp(aacfile, "-")) { retval = -1; } else { retval = fseek(b.infile, 0, SEEK_END); } #else retval = fseek(b.infile, 0, SEEK_END); #endif if (retval ) { faad_fprintf(stderr, "Input not seekable %s\n", aacfile); fileread = -1; streaminput = 1; } else { fileread = ftell(b.infile); fseek(b.infile, 0, SEEK_SET); }; -------------------- To get this into github, a new sbs.patch file will be needed, and I can generate that... ------------------------------------------------------------------------ utgg's Profile: http://forums.slimdevices.com/member.php?userid=40900 View this thread: http://forums.slimdevices.com/showthread.php?t=53229 _______________________________________________ plugins mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/plugins
