[EMAIL PROTECTED] wrote:
:Suggestion: Brad, can you (as the owner of the PodParser
:distribution) upload the atteched PodParser-1.20, which I compiled
:from recent suggestions on pod-people, direct mailings to
:me and the changes done in core Perl?
:
:As soon as this is on CPAN, Hugo (sorry, I don't know
:who this is, can somebody please copy him?) can include
:the relevant Pod/*.pm into the current Perl5 stream.
I had a go at integrating this into the core, but ran across some
test failures.
First, the core version of t/pod/find.t is substantially different
from the one in the distribution. That's kinda understandable, since
the one in the distribution thinks it knows all the files it should
find in ../lib, but the core version is also doing some strange
things; I don't understand this comment or code at all:
# The ../../../../../lib is for finding lib/utf8.pm
# when running under all-utf8 settings (pod/find.t)
# does not directly require lib/utf8.pm but regular
# expressions will need that.
@INC = qw(../lib ../../../../../lib);
I think in an ideal world the test in the distribution would work
a bit better in isolation (perhaps by generating its own test files,
or something), and if necessary check whether it is running as part
of the core or standalone by checking $ENV{PERL_CORE}. However the
current core version still passes all tests even with the latest code,
and we could just leave it there for now if this isn't an easy fix.
The other test failures are in lib/Pod/t/*:
crypt.org% ( cd t ; ./perl harness ../lib/Pod/t/{latex,utils}.t )
.../lib/Pod/t/latex....NOK 76# Test 76 got: 'Standard link: \emph{Pod::LaTeX}.
' (../lib/Pod/t/latex.t at line 63 fail #73)
# Expected: 'Standard link: the \emph{Pod::LaTeX} manpage.
'
# ../lib/Pod/t/latex.t line 63 is: ok($output$i, $reference$i);
.../lib/Pod/t/latex....NOK 80# Test 80 got: 'Now refer to an external section:
\textsf{sec} in \emph{Pod::LaTeX}
' (../lib/Pod/t/latex.t at line 63 fail #77)
# Expected: 'Now refer to an external section: the section on \textsf{sec} in the
\emph{Pod::LaTeX} manpage
'
.../lib/Pod/t/latex....FAILED tests 76, 80
Failed 2/154 tests, 98.70% okay
.../lib/Pod/t/utils....# Test 2 got: 'P<name>' (../lib/Pod/t/utils.t at line 46)
# Expected: 'the P<name> manpage'
# ../lib/Pod/t/utils.t line 46 is: ok($link->markup, $results$i);
# Test 3 got: 'Q<ident> in P<name>' (../lib/Pod/t/utils.t at line 46 fail #2)
# Expected: 'the Q<ident> entry in the P<name> manpage'
# Test 4 got: 'Q<sec> in P<name>' (../lib/Pod/t/utils.t at line 46 fail #3)
# Expected: 'the section on Q<sec> in the P<name> manpage'
# Test 5 got: 'Q<sec>' (../lib/Pod/t/utils.t at line 46 fail #4)
# Expected: 'the section on Q<sec> elsewhere in this document'
# Test 6 got: 'Q<sec>' (../lib/Pod/t/utils.t at line 46 fail #5)
# Expected: 'the section on Q<sec> elsewhere in this document'
.../lib/Pod/t/utils....FAILED tests 2-6
Failed 5/22 tests, 77.27% okay
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
.../lib/Pod/t/latex.t 154 2 1.30% 76 80
.../lib/Pod/t/utils.t 22 5 22.73% 2-6
Failed 2/2 test scripts, 0.00% okay. 7/176 subtests failed, 96.02% okay.
crypt.org%
... and I'm not sure whether we should just change the tests, or whether
they have a right to expect the text they did.
Hugo
