On Wed, 23 Jan 2019 at 10:12, zyx <z...@gmx.us> wrote: > P.S.: it would be nice to keep conversation on specific patch proposal, > not on random mail, where only its subject is changed, but the > threading is all wrong >
I definitely agree. > > On Mon, 2019-01-14 at 23:08 +0100, Francesco Pretto wrote: > > Fixes warnings in linux since the maximum value of EPdfDataType is > > 255 > > Hi, > I do not see that warning, and the maximum value of EPdfDataType is 10, > not 255 (11 values in the enum, 0 .. 10 inclusive). Maybe it's shown in > combination with other compiler options? I think I had the warning with clang (I can't confirm now, I'm compiling podofo with gcc/clang/VisualStudio). I quote myself in the other thread, it's about ePdfDataType_Unknown = 0xff, which is definitely 255: On Wed, 23 Jan 2019 at 09:05, Francesco Pretto <cez...@gmail.com> wrote: > Forgot to say: it passed some time so I don't remember precisely but > the change I did was mostly to fix warning issued by gcc or clang on > the switch of m_eDataType in PdfVariant.h inline methods. The maximum > value of EPdfDataType is ePdfDataType_Unknown = 0xff, so the switch > was complaining that one was switching on signed integer with values > that overflows the max integer value. So yes: switching to pdf_uint8 > should fix the warning I intended to fix. > ...so I'm currently favorable with the signed->unsigned change if it fixes the possible warning. _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
