Hi,
On Thu, 2019-01-24 at 17:43 +0100, Matthew Brincke wrote:
> It isn't the case that Michal wrote they were the same, he only wrote
> they are stored the same ....
yes, I know. My test-in-action showed that what is stored and how it
works are two different things. To make it bullet-proof the code needs
to work the same in both cases (storage and comparison). And it's not
the case. That's all I wanted to show.
> @zyx: Are you still vetoing that change of Francesco's (making
> Unknown equal to 0xff in EPdfDataType)?
My complain from the past was about the compiler warnings (as Francesco
pointed out in the archives). The two changes together (r1959 and the
proposal) will make it work flawlessly, without the warnings, thus my
original objection is gone. In other words, just do it.
> If not, I'll commit it after the fixes to the known security issues.
Why to postpone? Why to split related commits by other commits?
Consider the r1959 caused this lengthy discussion. It would be more
than logic to close the discussion in the next revision, in r1960, not
to have some gap and only then finish something ongoing, while it's
quite easy to forget of it. The changes I think of are: a) Unknown to
be 0xff; b) add comment above the change in r1959 explaining why it is
so. I would do a) and b) as one commit. The sooner you finish this
two-liner the better.
Bye,
zyx
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
