> weird, neither my checkout has it, nor the trunk: Oh my gosh, this is embarrassing: I have ePdfDataType_Unknown = 0xff because I pushed for this change some time ago[1]. I still have it applied in my tree because it because it's the contention used in other PoDoFo enums, and I somehow need it. While you understood the purpose of the change, you ended not applying it since it was causing such warnings, which I fixed in my tree with this change. You wrote:
On Sat, 10 Mar 2018 at 16:27, zyx <z...@gmx.us> wrote: > > On Thu, 2018-02-22 at 12:20 +0100, Francesco Pretto wrote: > > - ePdfDataType_Unknown /**< The Datatype is unknown > > */ > > + ePdfDataType_Unknown = 0xff /**< The Datatype is unknown */ > > Hi, > this change generates tons of compiler warnings like this one: > src/base/PdfVariant.h: In member function ‘bool > PoDoFo::PdfVariant::IsDirty() const’: > src/base/PdfVariant.h:954:9: warning: case label value exceeds maximum > value for type > thus I'm against it, even in cleans the code a bit. I ask you if we can move on with the change applied by Matthew, which I think is wise and has the benefit of accommodating the change I was aiming for. If you are reverting I will not complain but I kindly ask you to comment the code with a warning so nobody will attempt to change that underlying type anymore: I was confused enough and surely the code could have been more talkative in this case. [1] https://sourceforge.net/p/podofo/mailman/podofo-users/thread/0439eeb1a488653f84f7d66ea69f027cec4e6b97.camel%40gmx.us/#msg36249129 On Wed, 23 Jan 2019 at 12:39, zyx <z...@gmx.us> wrote: > > Hi, > > On Wed, 2019-01-23 at 10:35 +0100, Francesco Pretto wrote: > > it's about ePdfDataType_Unknown = 0xff, which is > > definitely 255: > > weird, neither my checkout has it, nor the trunk: > https://sourceforge.net/p/podofo/code/HEAD/tree/podofo/trunk/src/base/PdfDefines.h#l211 > nor 0.9.6 branch: > https://sourceforge.net/p/podofo/code/HEAD/tree/podofo/branches/PODOFO_0_9_6_BRANCH/src/base/PdfDefines.h#l211 > > Do I miss anything there? > Bye, > zyx > > > > > _______________________________________________ > Podofo-users mailing list > Podofo-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/podofo-users _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
