On 9/24/07, Pino Toscano <[EMAIL PROTECTED]> wrote:
> Why where they moved out of the private header?
> What's the problem with them being here?

GCC (rightly) complains about unused functions when those headers are
included in *.cc files that don't use those static functions. That
adds up to a lot of warnings.

They really should be in some common file shared between qt and qt4 to
avoid duplication of code.

Also I have a feeling that gcc isn't capable of removing
dead/duplicated code so I suspect multiple copies blow up binary size.
They should really be in a *.cc files, like all other functions.

-- kjk
_______________________________________________
poppler mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/poppler

Reply via email to