Alle lunedì 24 settembre 2007, Krzysztof Kowalczyk ha scritto:
> On 9/24/07, Pino Toscano <[EMAIL PROTECTED]> wrote:
> > Why where they moved out of the private header?
> > What's the problem with them being here?
>
> GCC (rightly) complains about unused functions when those headers are
> included in *.cc files that don't use those static functions. That
> adds up to a lot of warnings.

Then why don't move the implementation of both in a poppler-private.cc?
With the current solution, using one of these functions in more than one files 
would mean copying → bloat and not maintainable.
Albert?

> They really should be in some common file shared between qt and qt4 to
> avoid duplication of code.

Please keep qt and qt4 separated.

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
poppler mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/poppler

Reply via email to