Ping on this one.

Reviewer agreed version attached. Thanks.

Attachment: glances.tgz
Description: Binary data

Ashton Fagg <ash...@fagg.id.au> writes:

> Stuart Henderson <s...@spacehopper.org> writes:
>
>> OpenBSD uses ${SYSCONFDIR} (typically /etc) not /usr/local/etc for
>> config files, and they should be installed using @sample in PLIST so
>> that local edits don't break updates.
>>
>> The web interface (glances -w) requires py3-bottle, it's a small enough
>> dep so I think might as well just list in RUN_DEPENDS rather than write
>> a note in DESCR or a pkg-readme that people will ignore anyway.
>>
>> I also fixed whitespace nits (mix of "=" and " =") and put RUN_DEPENDS
>> in alpha order.
>>
>> It does do something odd with the naming of tmux processes though,
>> just shows them as "default)", not a show stopper for important but might
>> be worth poking at.
>>
>> This version is OK with me if someone wants to commit it..
>
> Thanks for the review, Stuart. I'll take a look at what's going on with
> the tmux processes.
>
> (also interest bump since I'm a few days late on replying - Stuart's
> fixed version attached)

Reply via email to