2007/4/18, Lars Hansson <[EMAIL PROTECTED]>:
Landry Breuil wrote: > Okay, so with feedback from Brad, Christian Rueger and Lawrence Teo, > i've reworked some diffs.. thanks for the input on USE_BZIP2 vs > EXTRACT_SUFX. I have some feedback on the previous patches so if you have fixed this, just ignore my points. Thunar: missing dependency on gconf2. It also looks like crap by default unless xfce-icon-theme is installed. Perhaps it should also depend on that.
Yep, i'll add dependency on the icon-theme.. forgot that (see http://thunar.xfce.org/pwiki/documentation/faq) . But for gconf2, it's an optional dependency to find available gnome-thumbnailers, and i don't think it's a good idea to make thunar depend on it.. it can use its own built-ins thumbnailers, and there is a separate goodies project here to be added to the ports : http://goodies.xfce.org/projects/thunar-plugins/thunar-thumbnailers xfce4-session: need to have xfce-mcs-manager a a build dependency. Okay, i'll add it xfce-utils: the /etc/xdg/xfce4 folder and xinitrc script is missing. thanks for pointing this out, i forgot to re-add the @sample to the PLIST @sample ${SYSCONFDIR}/xdg/xfce4/xinitrc Thanks for the feedback :) Landry
