Stuart Henderson <[email protected]> writes:
> Two small nits, otherwise ok;
>
> GH_ACCOUNT = tremc
> GH_PROJECT = tremc
> GH_COMMIT = 8b6b29163295e5cf12d9d874e80203c5906619c8
> DISTNAME = tremc-0.9.2
>
> if it is not the 0.9.2 release then please don't name it that.
>
> As it's some commit after 0.9.2 made on 27/2/2021 then I would using
> recommend tremc-0.9.2pl20210227. (If there was a release imminent
> and you knew it was going to be 0.9.3 then maybe 0.9.3pre20210227
> would make more sense).
I thought that it wouldn't cause problems with a future updates but it's
indeed wrong to call it 0.9.2 when it's not.
> RUN_DEPENDS = sysutils/py-pyperclip
>
> dependencies on python modules should have ${MODPY_FLAVOR} at the end
>
> RUN_DEPENDS = sysutils/py-pyperclip${MODPY_FLAVOR}
Yeah, I should have noticed that, sorry. Completely agree on both
points.
