On 2022-01-25 20:13:53, Stuart Henderson wrote:
> Two small nits, otherwise ok;
>
> GH_ACCOUNT =            tremc
> GH_PROJECT =            tremc
> GH_COMMIT =             8b6b29163295e5cf12d9d874e80203c5906619c8
> DISTNAME =              tremc-0.9.2
>
> if it is not the 0.9.2 release then please don't name it that.
>
> As it's some commit after 0.9.2 made on 27/2/2021 then I would using
> recommend tremc-0.9.2pl20210227. (If there was a release imminent
> and you knew it was going to be 0.9.3 then maybe 0.9.3pre20210227
> would make more sense).

You're completely right and I didn't even think about it. Thanks a lot.

>
> RUN_DEPENDS =           sysutils/py-pyperclip
>
> dependencies on python modules should have ${MODPY_FLAVOR} at the end
>
> RUN_DEPENDS =           sysutils/py-pyperclip${MODPY_FLAVOR}
>

Makes sense! net/tremc is after all a python3 port so we have to be
explicit and only use the python3 flavour of py-pyperclip.

On 2022-01-25 20:54:57, Omar Polo wrote:
>
> on a second thought, the tests need a xorg connection... since it's a
> simple library we've confirmed it works at runtime (I mean, it just exec
> xclip!) there's no need to be pedantic here.

The module is basically just a wrapper for xclip so.. yeah.
I mean tremc *works* in the TTY as well, you just don't get to copy
the magnet link which is no big deal in my opinion.


Tarballs attached yet again :)


Br,

Thim Cederlund

Attachment: tremc.tar.gz
Description: GNU Zip compressed data

Attachment: py-pyperclip.tar.gz
Description: GNU Zip compressed data

Reply via email to