On Thu, Feb 09, 2023 at 10:56:15AM +0100, Omar Polo wrote: > On 2023/01/08 15:11:02 +0100, Omar Polo <[email protected]> wrote: > > On 2023/01/07 13:56:26 -0500, Thomas Frohwein <[email protected]> > > wrote: > > > On Thu, Dec 29, 2022 at 11:45:23AM +0100, Omar Polo wrote: > > > [...] > > > > > > Just took a look at this - there is an extra PLIST file at > > > games/love/11/PLIST that is different from games/love/11/pkg/PLIST. > > > > Oops, no idea how that ended up there. shouldn't have been present. > > > > > I would probably at comment `# C++11` above the COMPILERS line in the > > > Makefile.inc. > > > > not sure, 0.8 is not (maybe?) C++11. and since love depends on other > > C++ libraries it can't be built with base-gcc on gcc arches anyway > > (that's my understanding at least, there ports-gcc is used to build > > C++ libs.) > > > > thfr and namtsui found that at least Blue Revolver actually needs > > luajit instead of lua. I'm attaching an updated tarball that builds > > the engine with luajit if available. (The only exception is love-0.8 > > that explicitly wants lua-5.1.) > > ping :) > > re-attaching the port, i've only tweaked slightly love/11 so that the > executable is called love-11 and not love-11.4. before 11.0, upstream > used a versioning scheme of 0.X.Y with X being breaking changes and Y > not, now they've changed to X.Y. So love-11.4 doesn't make sense for > an executable, just like love-0.10.2 is similarly wrong. love-11 and > love-0.10 make more sense. (the package name has the full version of > course.)
I built the ports the executables still contain the minor version (love-0.10.2 love-0.8.0 love-11.4), which isn't a problem for me at this point, but it sounds like you wanted that to be different. A few WANTLIB seem to be missing for love 0.8: $ make port-lib-depends-check love-0.8.0p14(games/love/0.8): Missing: Xau.10 (/usr/local/bin/love-0.8.0) (system lib) Missing: Xdmcp.11 (/usr/local/bin/love-0.8.0) (system lib) Missing: xcb-shm.1 (/usr/local/bin/love-0.8.0) (system lib) Extra: Xdamage.4 WANTLIB += Xau Xdmcp xcb-shm *** Error 1 in target 'port-lib-depends-check' (ignored) > > attaching a tarball because i'm completely changing the structure of > the port. > > ok to import? > I see no other issues, only the above. From my side this is ok thfr@ as long as WANTLIB is addressed; I'll leave the binary naming to you...
