On Wed, 24 Oct 2007 06:42:35 +0200 Jona Joachim <[EMAIL PROTECTED]> wrote:
> Hi! > This is my first openbsd port, I hope I did well. > It was very easy, it built out of the box. > > Could you please test and comment? > Thanks! > > Kind regards, > Jona Hi Jona, Thanks for your port. I have just reviewed it; here are a few comments: - keep lines below 80 chars in Makefile - don't use "V=" if you need it only once - there is no DESKTOP_FILES variable - configure outputs an error (problem with "test" near the end); this requires further investigation. - there is an implicit dependency on libglade, which was not listed. Either disable it explicitely in configure if it is not really needed, or list it as a dependency. - no need to put things in LIB_DEPENDS that will be pulled anyway. - I think BASE_PKGPATH should not appear in pkg/PLIST. - missing png in WANTLIB tested macppc. I noted the following problem: - on startup:(roxterm:16032): Gtk-WARNING **: Error loading icon from file '/usr/local/share/icons/hicolor/scalable/apps/roxterm.svg' Couldn't recognize the image file format for file '/usr/local/share/icons/hicolor/scalable/apps/roxterm.svg' - input is weird: backspace writes '~' instead of deleting for example. but that might be something with my setup. Others? Partially corrected tarball attached. Please have a look at the remaining issues, then I will commit. Eric.
roxterm.tgz
Description: Unix tar archive
