On Wed, 24 Oct 2007 20:13:25 -0400 Mike Erdely <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 24, 2007 at 10:03:00PM +0200, Eric Faurot wrote: > > Thanks for your port. I have just reviewed it; here are a few > > comments: > > > > - keep lines below 80 chars in Makefile > > - don't use "V=" if you need it only once > > - there is no DESKTOP_FILES variable > > - configure outputs an error (problem with "test" near the end); > > this requires further investigation. > > - there is an implicit dependency on libglade, which was not > > listed. Either disable it explicitely in configure if it is not > > really needed, or list it as a dependency. > > - no need to put things in LIB_DEPENDS that will be pulled anyway. > > - I think BASE_PKGPATH should not appear in pkg/PLIST. > > - missing png in WANTLIB > > New version that addresses all of this attached. > > The BASE_PKGPATH is due to the package not being built in $CATEGORY > (like /usr/ports/roxterm or /usr/ports/mystuff/roxterm; fwiw, I built > it in /usr/ports/mystuff/x11/roxterm). I built it in /usr/ports/mystuff/roxterm > DESKTOP_FILES is a gnome-ism (see /usr/ports/x11/gnome/gnome.port.mk). > AFAIK, it just adds :desktop-file-utils-*:devel/desktop-file-utils as > a RUN_DEPENDS. I picked it up when I took a look at the gnome-terminal port. I didn't know it was defined in gnome.port.mk, I should have checked. I don't think the devel/desktop-file-utils dependency is needed. > As I said, substituting /bin/test for test on the line referenced by > configure fixes the problem of the ksh built-in test not supporting > 'test $var < "0.30"' Oops, I missed that error in the configure output. > I've added some of the desktop icon magic from some of the x11/gnome/* > ports (like file-roller) to the pkg/PLIST (thanks jasper). > > I tested this on i386, macppc and sparc64. Unfortunately, I'm not in > front of either the macppc or sparc64, so I didn't notice any > backspace errors like you mention below. I am sitting in front of > the i386 and it works fine. I tested it on amd64 and it works fine here, too. > > tested macppc. I noted the following problem: > > > > - on startup:(roxterm:16032): Gtk-WARNING **: Error loading icon > > from file '/usr/local/share/icons/hicolor/scalable/apps/roxterm.svg' > > Couldn't recognize the image file format for file > > '/usr/local/share/icons/hicolor/scalable/apps/roxterm.svg' > > - input is weird: backspace writes '~' instead of deleting for > > example. > > The roxterm.svg error can be solved by including libsvg as a > RUN_DEPENDS. I'd personally rather live with the error message since > I don't install gnome and don't care if there's an roxterm.svg desktop > icon. Same for me. Thank you both very much for your work! Kind regards, Jona
