On Wed, Oct 24, 2007 at 10:03:00PM +0200, Eric Faurot wrote: > Thanks for your port. I have just reviewed it; here are a few > comments: > > - keep lines below 80 chars in Makefile > - don't use "V=" if you need it only once > - there is no DESKTOP_FILES variable > - configure outputs an error (problem with "test" near the end); this > requires further investigation. > - there is an implicit dependency on libglade, which was not > listed. Either disable it explicitely in configure if it is not > really needed, or list it as a dependency. > - no need to put things in LIB_DEPENDS that will be pulled anyway. > - I think BASE_PKGPATH should not appear in pkg/PLIST. > - missing png in WANTLIB
I've been working on this today. I'll post an update in a bit with all of these issues addressed. The fix for the test problem is to patch configure to use /bin/test for that line (ksh's built-in does not support test foo < bar). -ME
