On 2013/08/27 11:42, Craig R. Skinner wrote:
> ping
- don't distribute source files in ports
- don't use NO_CHECKSUM
- too many PERMIT_* lines
- don't have a MESSAGE just pointing people at the readme, pkg_add
already points people at the readme
- this is, err, not normal:
@echo '@mode ${SHAREMODE}\n@group ${SHAREGRP}' >> ${PLIST}
@echo 'share/doc/pkg-readmes/${FULLPKGNAME}' | tee -a ${PLIST}
@${SUBST_CMD} -c -g ${BINGRP} -o ${BINOWN} \
${FILESDIR}/${INST_DIR}/${DISTNAME} \
${PREFIX}/${INST_DIR}/${DISTNAME}
@echo '@mode ${BINMODE}\n@owner ${BINOWN}\n@group ${BINGRP}' | tee -a
${PLIST}
@echo "${INST_DIR}/${DISTNAME}" | tee -a ${PLIST}
- your local rcs history is pointless to include in the port
- script itself has security issues
