On 14:24 Tue 24 Dec , Jérémie Courrèges-Anglas wrote:
> Alexandr Shadchin <[email protected]> writes:
> 
> [...]
> 
> > Now ok for me. Does anyone have objections to import these ports ? or OK ?
> 
> Those ports look fine to me too.  There are a few minor glitches:
> - their build flags use -Wredundant-decls, this makes the build
>   unreadable and makes it hard to detect real problems.  Patching
>   configure is enough.
> - kyua-cli needs a patch for 32 bits archs (attached)
> - lutok build fine with lua5.2 but kyua-cli has lua5.1 hardcoded in its
>   WANTLIB.  I don't know what's the way to go, forcing one version of
>   lua for both ports, or using flavors and MODULES = /lang/lua in
>   kyua-cli?
> - I modified Sergey's patch for kyua-testers so that mounting tmpfs is
>   supported, and emulated lchmod instead instead of just removing the
>   call (also attached).

Thanks for review. I have corrected ports according to your comments.

> -- 
> jca | PGP: 0x06A11494 / 61DB D9A0 00A4 67CF 2A90  8961 6191 8FBF 06A1 1494

Attachment: lutok.tgz
Description: application/tar-gz

Attachment: kyua-cli.tgz
Description: application/tar-gz

Attachment: kyua-testers.tgz
Description: application/tar-gz

Reply via email to