On Wed, Apr 02, 2014 at 12:27:39PM +0200, David Coppa wrote: > On Wed, Apr 2, 2014 at 12:21 PM, David Coppa <dco...@gmail.com> wrote: > > On Wed, Apr 2, 2014 at 12:13 PM, Fabian Raetz <fabian.ra...@gmail.com> > > wrote: > >> Hi ports@, > >> > >> here is a port for Oxygen-Gtk theme from > >> http://kde-look.org/content/show.php/Oxygen+Gtk?content=136216 > >> > >> Oxygen-Gtk is a port of the default KDE widget theme (Oxygen), to gtk. > >> > >> Its primary goal is to ensure visual consistency between gtk and > >> qt-based applications running under kde. A secondary objective is to > >> also have a stand-alone nice looking gtk theme that would behave well on > >> other Desktop Environments. > >> > >> Unlike other attempts made to port the kde oxygen theme to gtk, this > >> attempt does not depend on Qt (via some Qt to Gtk conversion engine), > >> nor does render the widget appearance via hard coded pixmaps, which > >> otherwise breaks everytime some setting is changed in kde. > >> > >> > >> > >> > >> This makes Firefox & co looking like the rest when running KDE4. > >> If this port gets imported im willing to maintain it. > >> > >> Some questions i have: > >> - Do i have to use SHARED_ONLY / SHARED_LIBS? and if so, how > >> can i get cmake? to append the correct version to the lib? > >> > >> > >> Your feedback is welcome! > >> Port is attached. > > > > Add "SHARED_ONLY = Yes" on top of the Makefile, and remove SHARED_LIBS. > > You have nothing to do wrt CMake. CMake will handle things "automagically". > > > > Latest version is 1.4.4, btw... > > Another thing: I think "gtk2-oxygen-engine" is a more appropriate name. > > Ciao, > David
Hi David,
thanks for your immediate feedback. I incorporated your suggested changes and
fixed a portcheck warning (using ${PREFIX} in {,UN}MESSAGE).
Updated port is attached.
gtk2-oxygen-engine.tar.gz
Description: application/tar-gz
