I will take care of the gtk+2 part.
Thank you.
On Wed, Apr 02, 2014 at 03:54:51PM +0200, Fabian Raetz wrote:
> On Wed, Apr 02, 2014 at 01:54:57PM +0200, Antoine Jacoutot wrote:
> > On Wed, Apr 02, 2014 at 01:52:31PM +0200, Stefan Sperling wrote:
> > > On Wed, Apr 02, 2014 at 12:59:00PM +0200, Fabian Raetz wrote:
> > > > thanks for your immediate feedback. I incorporated your suggested
> > > > changes and
> > > > fixed a portcheck warning (using ${PREFIX} in {,UN}MESSAGE).
> > > >
> > > > Updated port is attached.
> > >
> > > Seems to work fine here with KDE4. Thanks!
> > >
> > > I'd suggest the following, mostly cosmetic, changes to the port.
> > >
> > > In my opinion having a README is better than MESSAGE/UNMESSAGE
> > > because the message can be missed while installing packages in bulk.
> New version attached.
>
> changes are:
> - added fix from upstream found by David
> - merged cosmetic changes from Stefan
> - removed MESSAGE, UNMESSAGE and README
> - bump REVISION
>
> >
> > I think such messages belongs in gtk+2 README.
> > Otherwize you end up duplicating the same information in all themes....
> >
> I have sligtly adjusted Stefan's README and merged it with the README
> from gtk+2. Here's the proposed diff to x11/gtk+2:
>
>
> Index: pkg/README-main
> ===================================================================
> RCS file: /cvs/ports/x11/gtk+2/pkg/README-main,v
> retrieving revision 1.2
> diff -u -p -r1.2 README-main
> --- pkg/README-main 2 Apr 2013 10:14:20 -0000 1.2
> +++ pkg/README-main 2 Apr 2014 13:52:10 -0000
> @@ -18,3 +18,8 @@ gtk-print-preview-command = "epdfview %f
> Note that by default, "evince" will remove the temporary PDF preview
> file (/tmp/previewXXXXX.pdf) which might not be the case with other PDF
> viewers.
> +
> +
> +If you want to use a different theme (like Oxygen-GTK) as your default
> +GTK theme include the theme's gtkrc file in ~/.gtkrc-2.0 with a line such as:
> + include "${PREFIX}/share/themes/oxygen-gtk/gtk-2.0/gtkrc"
>
>
> Cheers,
> Fabian
--
Antoine
