On Wed, Apr 02, 2014 at 01:52:31PM +0200, Stefan Sperling wrote:
> On Wed, Apr 02, 2014 at 12:59:00PM +0200, Fabian Raetz wrote:
> > thanks for your immediate feedback. I incorporated your suggested changes
> > and
> > fixed a portcheck warning (using ${PREFIX} in {,UN}MESSAGE).
> >
> > Updated port is attached.
>
> Seems to work fine here with KDE4. Thanks!
>
> I'd suggest the following, mostly cosmetic, changes to the port.
>
> In my opinion having a README is better than MESSAGE/UNMESSAGE
> because the message can be missed while installing packages in bulk.
I think such messages belongs in gtk+2 README.
Otherwize you end up duplicating the same information in all themes....
> diff -urN gtk2-oxygen-engine.orig/Makefile gtk2-oxygen-engine/Makefile
> --- gtk2-oxygen-engine.orig/Makefile Wed Apr 2 12:32:50 2014
> +++ gtk2-oxygen-engine/Makefile Wed Apr 2 13:07:51 2014
> @@ -1,5 +1,5 @@
> # $OpenBSD:$
> -COMMENT = default KDE widget theme (Oxygen), to gtk.
> +COMMENT = KDE Oxygen widget theme for GTK
>
> SHARED_ONLY = Yes
>
> diff -urN gtk2-oxygen-engine.orig/pkg/DESCR gtk2-oxygen-engine/pkg/DESCR
> --- gtk2-oxygen-engine.orig/pkg/DESCR Tue Apr 1 15:55:16 2014
> +++ gtk2-oxygen-engine/pkg/DESCR Wed Apr 2 13:09:55 2014
> @@ -1,11 +1,6 @@
> -Oxygen-Gtk is a port of the default KDE widget theme (Oxygen), to gtk.
> +Oxygen-Gtk is a port of the default KDE widget theme (Oxygen) to GTK.
>
> -Its primary goal is to ensure visual consistency between gtk and
> -qt-based applications running under kde. A secondary objective is to
> -also have a stand-alone nice looking gtk theme that would behave well on
> -other Desktop Environments.
> -
> -Unlike other attempts made to port the kde oxygen theme to gtk, this
> -attempt does not depend on Qt (via some Qt to Gtk conversion engine),
> -nor does render the widget appearance via hard coded pixmaps, which
> -otherwise breaks everytime some setting is changed in kde.
> +Its primary goal is to ensure visual consistency between GTK and
> +QT-based applications running under KDE. A secondary objective is to
> +also have a stand-alone nice looking GTK theme that behaves well in
> +other desktop environments.
> diff -urN gtk2-oxygen-engine.orig/pkg/MESSAGE gtk2-oxygen-engine/pkg/MESSAGE
> --- gtk2-oxygen-engine.orig/pkg/MESSAGE Wed Apr 2 12:47:36 2014
> +++ gtk2-oxygen-engine/pkg/MESSAGE Thu Jan 1 01:00:00 1970
> @@ -1,4 +0,0 @@
> -If you want to use this theme as your default theme,
> -include the theme's gtkrc file into your ~/.gtkrc-2.0
> -and restart your window manager:
> - echo 'include "${PREFIX}/share/themes/oxygen-gtk/gtk-2.0/gtkrc"' >>
> ~/.gtkrc-2.0
> diff -urN gtk2-oxygen-engine.orig/pkg/PLIST gtk2-oxygen-engine/pkg/PLIST
> --- gtk2-oxygen-engine.orig/pkg/PLIST Wed Apr 2 12:39:59 2014
> +++ gtk2-oxygen-engine/pkg/PLIST Wed Apr 2 13:47:13 2014
> @@ -1,6 +1,7 @@
> @comment $OpenBSD$
> @bin bin/oxygen-gtk-demo
> lib/gtk-2.0/2.10.0/engines/liboxygen-gtk.so
> +share/doc/pkg-readmes/${FULLPKGNAME}
> share/themes/oxygen-gtk/
> share/themes/oxygen-gtk/gtk-2.0/
> share/themes/oxygen-gtk/gtk-2.0/argb-apps.conf
> diff -urN gtk2-oxygen-engine.orig/pkg/README gtk2-oxygen-engine/pkg/README
> --- gtk2-oxygen-engine.orig/pkg/README Thu Jan 1 01:00:00 1970
> +++ gtk2-oxygen-engine/pkg/README Wed Apr 2 13:13:01 2014
> @@ -0,0 +1,10 @@
> +$OpenBSD$
> +
> ++-----------------------------------------------------------------------
> +| Running ${FULLPKGNAME} on OpenBSD
> ++-----------------------------------------------------------------------
> +
> +If you want to use Oxygen-GTK as your default GTK theme include
> +the theme's gtkrc file in ~/.gtkrc-2.0 with a line such as:
> +
> + include "${PREFIX}/share/themes/oxygen-gtk/gtk-2.0/gtkrc"
> diff -urN gtk2-oxygen-engine.orig/pkg/UNMESSAGE
> gtk2-oxygen-engine/pkg/UNMESSAGE
> --- gtk2-oxygen-engine.orig/pkg/UNMESSAGE Wed Apr 2 12:44:46 2014
> +++ gtk2-oxygen-engine/pkg/UNMESSAGE Thu Jan 1 01:00:00 1970
> @@ -1,3 +0,0 @@
> -Don't forget to remove the following line from
> -your ~/.gtkrc-2.0:
> - include "${PREFIX}/share/themes/oxygen-gtk/gtk-2.0/gtkrc"
>
--
Antoine
