On 2014-08-22 21:10:04, Chuck Burns <brea...@gmail.com> wrote:
> Quassel is my favorite GUI IRC client.  It's a distributed IRC client.
> Think screen+irssi with a GUI. This is also my very first attempt at an
> OpenBSD port of anything, so don't hurt me. :)
> 
> I eventually intend to make it into a multi part package, but not really
> sure yet how best to proceed.
> 
> Because there are three different apps here. some people might only need 1
> or 2.. or want all three (rare)
> 
> Here's how it works:
> There's the "core" which is the daemon
> There's the "client" which is .. well.. the client.
> 
> Then, there's also a "monolithic app" which does away with the distributed
> nature of the app, and makes it a simple standalone IRC client.
> 
> So.. One box might have the core, several boxes might have the client..
> 
> Or, someone might just install the monolithic client.  The tarball can
> build all of them or some of them. I haven't yet figured out my best course
> of action on that..
> 
> In the meantime, please test this port and give me a thrashing if I screwed
> up (which is likely)
> 
> Thanks,
> Chuck Burns

Seems to build and run fine for me, though I did not perform
extended testing.

Three comments.  First, the licence file doesn't say GPL2+, it
says the following:

        This program is free software; you can redistribute it
        and/or modify it under the terms of the GNU General Public
        License as published by the Free Software Foundation;
        either version 2 of the License, or (at your option)
        version 3.

So it's *either* GPL2 or GPL3.  GPL4 (if/when it comes out) would
not be an option like it would for the licences that say "any
later version" as is usually the case, which is how the template
at https://gnu.org/licenses/gpl-howto.html is written.

The second comment is that the binaries are not being stripped.
The stripped versions in the following directory were created
manually by myself, after it had finished building.

% ls -lah
total 494376
drwxr-xr-x   2 root  wheel   512B Aug 23 14:50 .
drwxr-xr-x  11 root  wheel   512B Aug 23 14:41 ..
-rwxr-xr-x   1 root  wheel   108M Aug 23 13:02 quassel
-rwxr-xr-x   1 root  wheel   6.5M Aug 23 14:45 quassel.stripped
-rwxr-xr-x   1 root  wheel  85.9M Aug 23 13:03 quasselclient
-rwxr-xr-x   1 root  wheel   5.1M Aug 23 14:50 quasselclient.stripped
-rwxr-xr-x   1 root  wheel  32.8M Aug 23 13:03 quasselcore
-rwxr-xr-x   1 root  wheel   3.3M Aug 23 14:50 quasselcore.stripped

So the total install size would decrease from about 226 MB to about
15 MB if the binaries were stripped.  This is probably something
worth doing.

Third, "make port-lib-depends-check" says that WANTLIB should
should have the following added to it:
        WANTLIB += QtScript QtSql QtXmlPatterns c m phonon pthread z

Other than that, it looks okay to me, but a more experienced
porter would probably be able to provide better feedback.

-- 
Bryan

Reply via email to