On Saturday, August 23, 2014 3:26:07 PM Bryan Linton wrote:
> Seems to build and run fine for me, though I did not perform
> extended testing.
>
> Three comments. First, the licence file doesn't say GPL2+, it
> says the following:
>
> This program is free software; you can redistribute it
> and/or modify it under the terms of the GNU General Public
> License as published by the Free Software Foundation;
> either version 2 of the License, or (at your option)
> version 3.
>
> So it's *either* GPL2 or GPL3. GPL4 (if/when it comes out) would
> not be an option like it would for the licences that say "any
> later version" as is usually the case, which is how the template
> at https://gnu.org/licenses/gpl-howto.html is written.
>
> The second comment is that the binaries are not being stripped.
> The stripped versions in the following directory were created
> manually by myself, after it had finished building.
>
> % ls -lah
> total 494376
> drwxr-xr-x 2 root wheel 512B Aug 23 14:50 .
> drwxr-xr-x 11 root wheel 512B Aug 23 14:41 ..
> -rwxr-xr-x 1 root wheel 108M Aug 23 13:02 quassel
> -rwxr-xr-x 1 root wheel 6.5M Aug 23 14:45 quassel.stripped
> -rwxr-xr-x 1 root wheel 85.9M Aug 23 13:03 quasselclient
> -rwxr-xr-x 1 root wheel 5.1M Aug 23 14:50 quasselclient.stripped
> -rwxr-xr-x 1 root wheel 32.8M Aug 23 13:03 quasselcore
> -rwxr-xr-x 1 root wheel 3.3M Aug 23 14:50 quasselcore.stripped
>
> So the total install size would decrease from about 226 MB to about
> 15 MB if the binaries were stripped. This is probably something
> worth doing.
>
> Third, "make port-lib-depends-check" says that WANTLIB should
> should have the following added to it:
> WANTLIB += QtScript QtSql QtXmlPatterns c m phonon pthread z
>
> Other than that, it looks okay to me, but a more experienced
> porter would probably be able to provide better feedback.
So, I wonder why it didn't automatically strip them, like the Porter's
Handbook says it will.
"Executables are stripped by default; this is governed by
${INSTALL_STRIP}. ${INSTALL_PROGRAM} honors this automatically and is
preferable to unconditional stripping (e.g., by an install-strip target or by
running strip from the Makefile). You can use file(1) to determine if a
binary is stripped or not. "
Hmm. And thanks for the 2nd part. I thought I ran that part, but I guess
between having to smack Ninja around and finally giving up to force it to
just use Makefiles.... I must have missed that step.
The port doesn't seem to build any executables when using the ninja build
system. I don't know why.
Thanks for the feedback. I'll up another iteration after I have a chance to
look at some things.
Chuck
