On Fri Apr 17, 2015 at 05:37:32PM +0200, Ingo Feinerer wrote:
> Update of math/R to 3.2.0 (released yesterday):
> 
> - Delete patches/patch-src_main_Rstrptime_h
>   This patch was processed upstream (in modified form) upon my request:
>   
> https://github.com/wch/r-source/commit/93efce2d8eb870b0554272f392d6a2343ba6ede8

Nice to see, good work Ingo.

> 
> - Remove PREFIX and INSTALL* in FAKE_FLAGS and MAKE_FLAGS
>   Builds and installs fine without.

looks okay for me

> 
> - Remove all --with-* configure options which are true by default

ACK;

> 
> - Add devel/libidn and net/curl in LIB_DEPENDS
>   (based on "make port-lib-depends-check")
>   and adapt WANTLIB accordingly

okay for curl, but it's not set as default option true.

> 
> - Avoid setting ac_cv_path_TAR as it works without

Are your sure, R pick up gtar?

> 
> - Remove non-working mirrors from MASTER_SITES
> 
> - Increase SHARED_LIBS R version number as the exported symbols changed
>   (checked by comparing old and new library with "nm -g").

ACK;

> 
> Passes all tests and works with my personal R packages and scripts.
> Tested on amd64.

Tested on amd64. All regressions passed.


> 
> Remarks:
> 
> - I have
> 
>   LDFLAGS=-L/usr/local/lib
>   CFLAGS=-I/usr/local/include
> 
>   in my .R/Makevars. This is very useful if you install packages which
>   need to compile some C code at installation. Should this info be
>   included in pkg/README?

I think it's a good advice.

> 
> - Moreover, I am willing to take MAINTAINERship just in case Rafael
>   Sadowski is no longer interested. I plan to provide updates in the
>   future as well as I need a current R version for my work/research.
> 

I'm interested but I think you're the better men for this port. You're
closer to the R community and (more or less) a daily R user on OpenBSD.
I will not stand in the way.

Cheers, Rafael

Reply via email to