2015-07-10 8:19 GMT+03:00 David CARLIER <[email protected]>: > Hi everybody, > > Here is a port for a library I maintain which provides device detection. I > send it as a shar archive if it is ok with you.
Please read porting guide first: http://www.openbsd.org/faq/ports/ Now some comments (likely not all): 1. Shar are not welcome here. In this particular it's more or less ok since it's pure text, but in general we expect tar archives, please use them next time. 2. No $OpenBSD$ markers. 3. .orig files should be removed. 4. It looks like your editor thinks that tab is not 8 characters, but 4, or even two. Look how bad this file looks like here in screenshot (attached). 5. No license marker. 6. PERMIT_* aren't booleans, they should be either a "Yes" string, or a description why package/distfiles may not be distributed this way. 7. I can't test the actual port since I'm not registered at the website, and I don't want to do this. What does distfile license says exactly? 8. Why "mv ${WRKDIR}/${PKGNAME} ${WRKDIR}/${DISTNAME}"? You can just set WRKDIST variable. 9. Until I came up to the homepage, I didn't realize this is actually a HA-Proxy module. Likely many other people will be curious, too. Please, rework the DESCR. 10. "Device Detection" (in COMMENT) shouldn't be capitalized, no? -- WBR, Vadim Zhukov
