Hi, here a new "patches" version. Thanks.
Regards. On 10 July 2015 at 21:07, David CARLIER <[email protected]> wrote: > > > On 10 July 2015 at 20:35, Vadim Zhukov <[email protected]> wrote: > >> 2015-07-10 13:23 GMT+03:00 David CARLIER <[email protected]>: >> > This version should be slighty better, hopefully. >> > >> > Thanks. >> >> Yes, it's much better now. Two more nits I see now: >> >> 1. USE_LIBTOOL=Yes is extraneous, as this is the default value. >> >> > Ok good to know > > >> 2. The INSTALL_PREFIX is a place where the package built will be >> installed, and not the place where dependencies are expected to be >> found, which LOCALBASE defines. Actually, CMake defaults to a correct >> value, unless you try to override it in CMakeLists.txt. So if you >> don't override it, you don't need CONFIGURE_ARGS line at all, either. >> Otherwise, you'd replace ${LOCALBASE} with ${TRUEPREFIX}. See the >> definition of LOCALBASE, PREFIX and TRUEPREFIX in bsd.port.mk(5). >> >> > Ok thanks. > > >> 3. Does your software have tests? If no, please add the NO_TEST=Yes to >> the port's Makefile. Otherwise, please, make sure that "make test" >> works. >> >> > Ok, we have some unit tests but not shipped with the archives. So ok will > apply this variable too. > > >> After this I see this port okay from "outside" part. But it still >> needs to be built & tested by someone else here; I won't, sorry, even >> taking into account your kindness during port review. >> >> > It is understandable ;-) thanks for your time. > > >> -- >> WBR, >> Vadim Zhukov >> > >
deviceatlas-enterprise-c.tar
Description: Unix tar archive
