attila wrote:
> The attached patch brings textproc/multimarkdown up to the latest
> release (5.1.0). It ditches a bunch of patches, some of which are no
> longer necessary and some of which I tried and failed to sell to the
> upstream.
Do you think any of these patches are worth keeping around regardless
for security reasons?
That said, I would drop the rand(3) removals. We alias it to
arc4random(3) anyway. One of the main benefits of that is that we don't
have to maintain tons of patches.
Also, a few comments inline:
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/textproc/multimarkdown/Makefile,v
> retrieving revision 1.2
> diff -u -p -r1.2 Makefile
> --- Makefile 5 Apr 2015 13:31:15 -0000 1.2
> +++ Makefile 16 Mar 2016 01:00:52 -0000
> @@ -21,14 +21,18 @@ WANTLIB += c
> BUILD_DEPENDS = devel/greg
>
> USE_GMAKE = Yes
> -ALL_TARGET = ALL
> -MAKE_FLAGS = CFLAGS="${CFLAGS} -include GLibFacade.h -DHAVE_ARC4RANDOM" \
> - GREG=${LOCALBASE}/bin/greg
> +# avoid using cmake, not necc for us
> +ALL_TARGET = deprecated
> +
> +# golf MAKE_FLAGS down to 80chars.. :-|
> +_i = -include
> +_incs = ${_i} src/GLibFacade.h ${_i} src/version.h ${_i}
> src/parser.h
> +MAKE_FLAGS = CFLAGS="${CFLAGS} ${_incs}"
Why golf? Can't you just use backslashes as necessary? I would get rid
of _i and _incs.
