On 2016/03/19 15:38, Michael McConville wrote:
> > +ALL_TARGET = deprecated
> > +
> > +# golf MAKE_FLAGS down to 80chars.. :-|
> > +_i = -include
> > +_incs = ${_i} src/GLibFacade.h ${_i} src/version.h ${_i}
> > src/parser.h
> > +MAKE_FLAGS = CFLAGS="${CFLAGS} ${_incs}"
>
> Why golf? Can't you just use backslashes as necessary? I would get rid
> of _i and _incs.
>
I think this approach is dangerous, better to keep those bits which are
normally part of upstream's Makefile in their Makefile and change the
way that you pass in CFLAGS. (e.g. maybe pass in COPTFLAGS instead and
change their Makefile to do COPTFLAGS?=-O3 and "CFLAGS?=${COPTFLAGS} ...
-include ...")
But then again, we have cmake, why not just use that? It's upstream's
preferred build infrastructure, whereas for the make-based one they say
"I don't recommend this approach, but it should work in a pinch"..
