Hi Sebastien,

Many thanks for the review. I think I have fixed issues you pointed to.

It would be great if someone can comment on setting PATH inside
MAKE_ENV. 

Changes made since my last submission:
- Patches are updated with my comments
- OpenBSD profiling handler has been accepted into the upstream
  development branch [1]. However, mlton-20130715 release still needs
  to be patched
- Codegen patches are hopefully temporary only - until the next
  MLton release (See [2])
- .orig files removed
- .if logic around DISTFILES removed
- Unnecessary PERMIT_* statements removed
- WITH_GMP does exist in several places and is needed to setup proper
  gmp prefix. Not changed.
- bootstrap copying stuff moved to the post-extract target
- mv is used instead of cp
- Build and install target are separate now

Additional notes:
- Some tests will fail, that is expected. See [3]
- Bootstrap target requires 2Gb of RAM - MLton is a whole-program
  compiler

Updated port archive attached, please test if possible.


[1]: https://github.com/MLton/mlton/pull/149
[2]: https://github.com/MLton/mlton/issues/148
[3]: https://github.com/MLton/mlton/issues/145


Best regards,
Alex

Attachment: mlton.tar.gz
Description: application/gzip

Reply via email to