Thanks Sebastien, please see my comments inline. > the port is fairly complete. Just some points: > - patches/patch-mlton_Makefile > "PREFIX has to be /usr/local for OpenBSD" > > in fact, "/usr/local" shouldn't be directly used: you should use > LOCALBASE variable (default to /usr/local)
Changed /usr/local to LOCALBASE, also added link to a relevant discussion on MLton build system updates. > > - patches/patch-runtime_platform_openbsd_c > "This has been added into the development branch of MLton" > > could you add a link to the commit in the description ? Added links to the corresponding upstream commits in openbsd.c, main.fun, Makefile patch files. Diff and updated port archive are attached. Best, Alex
diff -ruN mlton.orig/patches/patch-Makefile mlton/patches/patch-Makefile --- mlton.orig/patches/patch-Makefile Fri Jul 8 18:17:50 2016 +++ mlton/patches/patch-Makefile Fri Jul 8 18:16:45 2016 @@ -1,21 +1,27 @@ $OpenBSD$ -1. PREFIX has to be /usr/local for OpenBSD -2. Do not gzip manpages on OpenBSD +1. Use PREFIX:=$(LOCALBASE) on OpenBSD. + Note that MLton build system is being updated and this change + might be not needed for later releases. + https://github.com/MLton/mlton/issues/131 +2. Do not gzip manpages on OpenBSD. Committed upstream: + https://github.com/MLton/mlton/commit/8c97afed578453023c05c51d071855fc9e64ecdf 3. BSD tar does not support "--exclude" option. See https://github.com/MLton/mlton/issues/146 for more detail ---- Makefile.orig Mon Jul 15 19:59:09 2013 -+++ Makefile Thu May 26 13:01:56 2016 -@@ -284,7 +284,7 @@ check: +--- Makefile.orig Tue Jul 16 07:59:09 2013 ++++ Makefile Fri Jul 8 17:34:03 2016 +@@ -284,8 +284,8 @@ check: # puts them. DESTDIR := $(CURDIR)/install PREFIX := /usr -ifeq ($(findstring $(TARGET_OS), darwin freebsd solaris), $(TARGET_OS)) +-PREFIX := /usr/local +ifeq ($(findstring $(TARGET_OS), darwin freebsd openbsd solaris), $(TARGET_OS)) - PREFIX := /usr/local ++PREFIX := $(LOCALBASE) endif ifeq ($(TARGET_OS), mingw) + PREFIX := /mingw @@ -303,7 +303,7 @@ endif TEXM := $(TDOC)/examples diff -ruN mlton.orig/patches/patch-mlton_main_main_fun mlton/patches/patch-mlton_main_main_fun --- mlton.orig/patches/patch-mlton_main_main_fun Fri Jul 8 18:17:50 2016 +++ mlton/patches/patch-mlton_main_main_fun Fri Jul 8 18:16:45 2016 @@ -1,6 +1,7 @@ $OpenBSD$ -Use PIC on OpenBSD +Use PIC on OpenBSD. Committed upstream: +https://github.com/MLton/mlton/commit/5a580cc3d8d34910e8d39d95c2a47e21548dc403 --- mlton/main/main.fun.orig Mon Jun 13 08:25:46 2016 +++ mlton/main/main.fun Mon Jun 13 08:28:25 2016 diff -ruN mlton.orig/patches/patch-runtime_platform_openbsd_c mlton/patches/patch-runtime_platform_openbsd_c --- mlton.orig/patches/patch-runtime_platform_openbsd_c Fri Jul 8 18:17:50 2016 +++ mlton/patches/patch-runtime_platform_openbsd_c Fri Jul 8 18:16:45 2016 @@ -2,6 +2,7 @@ Add OpenBSD profiling handler for MLton-20130715. This has been added into the development branch of MLton. +https://github.com/MLton/mlton/commit/028a9fc396053ed9ed2135cc84bee85af87b7374 --- runtime/platform/openbsd.c.orig Thu May 26 13:06:51 2016 +++ runtime/platform/openbsd.c Thu May 26 13:05:24 2016
mlton.tar.gz
Description: application/gzip
