On Sat, 9 Jul 2016 06:46:08 +0200 Sebastien Marie <[email protected]> wrote: <..> > > $ cd lang/mlton && portcheck > trailing whitespace in Makefile > 3 line(s) longer than 80 chars in Makefile > hardcoded paths detected in Makefile, consider using SUBST_VARS and > TRUEPREFIX/LOCALBASE/LOCALSTATEDIR/VARBASE Makefile does not have > $OpenBSD$ RCS tag at the top 1 line(s) longer than 80 chars in > pkg/DESCR Python module without compiled version, consider using > ${MODPY_BIN} ${MODPY_LIBDIR}/compileall.py: > lib/mlton/sml/smlnj-lib/HTML4/helper.py lang/mlton <..>
Thanks Sebastien, all fixed, except compileall.py warning. I believe compiled version of helper script is not required in this case. It is an executable script, not a library, and no .pyc will be generated. I also doubt that anyone will run this script - besides the developers of MLton compiler. Diff and port archive are attached. Best, Alex
diff -ruN mlton.orig/Makefile mlton/Makefile
--- mlton.orig/Makefile Sat Jul 9 18:28:03 2016
+++ mlton/Makefile Sat Jul 9 18:27:22 2016
@@ -1,3 +1,5 @@
+# $OpenBSD$
+
COMMENT = MLton compiler
V = 20130715
DISTNAME = mlton-${V}
@@ -32,31 +34,33 @@
MAKE_ENV = PATH=${PATH}:${WRKBUILD}/build/bin/:${WRKBUILD}/mllex/
post-extract:
- mv ${WRKDIR}/bootstrap ${WRKBUILD}/
+ mv ${WRKDIR}/bootstrap ${WRKBUILD}/
do-build:
# Prerequisites, directory layout
- cd ${WRKBUILD} && WITH_GMP=/usr/local ${GMAKE} dirs runtime
+ cd ${WRKBUILD} && WITH_GMP=${PREFIX} ${GMAKE} dirs runtime
# Compile, link MLton compiler executable from bootstrap C sources,
# because we do not have any SML compiler available yet.
- # Also copy bootstrap files for mlyacc.
+ # Also copy bootstrap files for mlyacc.
cd ${WRKBUILD} && ${MAKE} -C bootstrap compile_bootstrap
cd ${WRKBUILD} && mv bootstrap/mlton-compile build/lib/
cd ${WRKBUILD} && mv bootstrap/yacc.grm.* mlyacc/src/
# Now build the rest with the bootstrapped MLton compiler
- cd ${WRKBUILD} && ${GMAKE} basis-no-check script mlbpathmap constants libraries
+ cd ${WRKBUILD} \
+ && ${GMAKE} basis-no-check script mlbpathmap constants libraries
cd ${WRKBUILD} && PATH=${PATH}:${WRKBUILD}/mllex/ ${GMAKE} tools
# bootstrap target generates MLton (and mlyacc) bootstrap files
BOOTSTRAP_DIR= ${WRKDIR}/bootstrap-new/bootstrap
bootstrap: fake
cd ${WRKBUILD} && ${GMAKE} # First round of compilation
- # Recompile mlton with itself, keep intermediary files for further use as bootstrap.
+ # Recompile mlton with itself, keep intermediary files
+ # for further use as bootstrap.
# Extra recompilation cycle makes sense when MLton versions change.
- cd ${WRKBUILD}/mlton && ${GMAKE} clean
+ cd ${WRKBUILD}/mlton && ${GMAKE} clean
cd ${WRKBUILD}/mlton && rm -f mlton-compile
- cd ${WRKBUILD} && PATH=${PATH}:${WRKBUILD}/build/bin/ COMPILE_ARGS=" -keep g " ${GMAKE}
-
+ cd ${WRKBUILD} && PATH=${PATH}:${WRKBUILD}/build/bin/ \
+ COMPILE_ARGS=" -keep g " ${GMAKE}
# Archive bootstrap files
mkdir -p ${BOOTSTRAP_DIR}
mv ${WRKBUILD}/mlton/*.c ${BOOTSTRAP_DIR}
@@ -64,7 +68,10 @@
mv ${WRKBUILD}/mlyacc/src/yacc.grm.* ${BOOTSTRAP_DIR}
mv ${WRKBUILD}/bootstrap/Makefile ${BOOTSTRAP_DIR}
mv ${WRKBUILD}/bootstrap/README ${BOOTSTRAP_DIR}
- cd ${WRKDIR}/bootstrap-new/ && tar zcf mlton-${V}-bootstrap-OpenBSD-${OSREV}-${MACHINE_ARCH}.tar.gz bootstrap
+ cd ${WRKDIR}/bootstrap-new/ && \
+ tar zcf \
+ mlton-${V}-bootstrap-OpenBSD-${OSREV}-${MACHINE_ARCH}.tar.gz \
+ bootstrap
.include <bsd.port.mk>
diff -ruN mlton.orig/pkg/DESCR mlton/pkg/DESCR
--- mlton.orig/pkg/DESCR Sat Jul 9 18:28:03 2016
+++ mlton/pkg/DESCR Sat Jul 9 18:27:22 2016
@@ -1 +1,2 @@
-MLton is a whole-program optimizing compiler for the Standard ML programming language.
+MLton is a whole-program optimizing compiler for the Standard ML
+programming language.
mlton.tar.gz
Description: application/gzip
