On Thu, Jun 28, 2018 at 09:16:33AM +0300, Leonid Bobrov wrote:
> Thanks to latest commit from espie@ (new tag) I have to resend my diff
> for games/minetest, I won't resend minetest_game.tar.gz because it is
> unchanged:
I havent tested your diff yet (we're all doing this on our spare time,
and we have other battlefields..) but one thing looks wrong:
> +.if ! ${BUILD_PACKAGES:M-main}
> +CONFIGURE_ARGS+= -DBUILD_CLIENT=FALSE
> +.endif
> +
> +.if ${BUILD_PACKAGES:M-server}
> +CONFIGURE_ARGS+= -DBUILD_SERVER=TRUE
> +.endif
This seems like you want to handle the case of someone just wanting to
build the server, but there are no user knobs like a pseudo flavor, and
in that case its not necessary imo. Just add -DBUILD_SERVER=TRUE to
CONFIGURE_ARGS inconditionally, both will get built. End users use
packages.
Another nit, iirc i've seen in the upstream CMakeFiles that external
jsoncpp was disabled by default because it could lead to
crashes/corruptions, have you looked into why, to make sure this is safe
to enable ?
