On Thu, Jun 28, 2018 at 08:49:08AM +0200, Landry Breuil wrote: > This seems like you want to handle the case of someone just wanting to > build the server, but there are no user knobs like a pseudo flavor, and > in that case its not necessary imo. Just add -DBUILD_SERVER=TRUE to > CONFIGURE_ARGS inconditionally, both will get built. End users use > packages. >
Also one more mistake I made in this condition is that if someone builds only client, that someone will get error when will try to install it because that'll make server unpackageable. Ok, fixed. > > Another nit, iirc i've seen in the upstream CMakeFiles that external > jsoncpp was disabled by default because it could lead to > crashes/corruptions, have you looked into why, to make sure this is safe > to enable ? > I rely on documentation written in README files, if some option is not safe, I expect to be stated so explicitly. If documentation is unclear (i.e. it doesn't work for me or it is confusing), I complain. So I was not aware of this problem. The only issue I've found so far is that in 2014 year it crashed Minetest when trying to retrieve server list: https://github.com/minetest/minetest/issues/1793 and that issue is closed because 3 years later it stoped crashing. So yeah I am sure it is safe.
