On 2018/06/28 10:53, Leonid Bobrov wrote:
> I rely on documentation written in README files, if some option is not
> safe, I expect to be stated so explicitly.
that approach isn't going to work very well.
> +.include <bsd.port.arch.mk>
> +.if ! ${BUILD_PACKAGES:M-main}
> +CONFIGURE_ARGS+= -DBUILD_CLIENT=FALSE
> +.endif
As landry@ pointed out you aren't setting PSEUDO_FLAVORS so you can't do
anything with the BUILD_PACKAGES mechanism anyway, so there is no need for
the above lines.
> +CONFIGURE_ARGS = -DENABLE_GETTEXT=TRUE -DCUSTOM_MANDIR=${PREFIX}/man
> +CONFIGURE_ARGS+= -DENABLE_SYSTEM_JSONCPP=TRUE -DUSE_GPROF=TRUE
> +CONFIGURE_ARGS+= -DBUILD_SERVER=TRUE
Can you split these out onto separate lines please, for example
CONFIGURE_ARGS = -DENABLE_GETTEXT=TRUE \
-DCUSTOM_MANDIR=${PREFIX}/man \
-DENABLE_SYSTEM_JSONCPP=TRUE \
-DUSE_GPROF=TRUE \
-DBUILD_SERVER=TRUE
so it's easier to read.
> Index: pkg/PLIST-server
> ===================================================================
> RCS file: pkg/PLIST-server
> diff -N pkg/PLIST-server
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ pkg/PLIST-server 28 Jun 2018 07:51:23 -0000
> @@ -0,0 +1,319 @@
> +@comment $OpenBSD: PLIST-server,v$
> +@bin bin/minetestserver
> +@man man/man6/minetestserver.6
> +share/doc/minetest/
[..]
Because you moved existing files to PLIST-server you need a line registering
the conflict with the old package:
@conflict minetest-<=0.4.17.1p1
(This isn't needed in PLIST-main because it has the same PKGNAME 'stem' as
the old package).
