On 5/13/2011 9:27 AM, Arjan van de Ven wrote: > On 5/13/2011 9:19 AM, Mathew, JohnX wrote: >>> -----Original Message----- >>> From: Arjan van de Ven [mailto:[email protected]] >>> Sent: Friday, May 13, 2011 6:49 PM >>> To: Mathew, JohnX >>> Cc: [email protected] >>> Subject: Re: [PATCH] Add support for universal power supply monitor >>> >>> On 5/13/2011 7:50 AM, John Mathew wrote: >>>> This patch enables powertop to display power estimates on >>>> devices that implement power_supply class and donot have >>>> acpi battery interface. >>> I like your code.... one question..... >>> is there any reason to still use/have the acpi one? >>> or maybe only probe the acpi code if this one does not find any sources? >> Desktops implement the acpi battery interface, but they also support the >> power_supply class too. So I think it can be removed. > and there's feature parity ? > (if there is... then yeah we should delete the Acpi code)
(just as background, I'm hesitating putting your patch in without removing the acpi code, since I don't think having 2 concurrent power meters is going to work very well.... I'd like to just go forward with your code only) _______________________________________________ Power mailing list [email protected] https://bughost.org/mailman/listinfo/power
