>-----Original Message----- >From: [email protected] [mailto:[email protected]] On >Behalf Of Arjan van de Ven >Sent: Friday, May 13, 2011 7:38 PM >To: [email protected] >Subject: Re: [PATCH] Add support for universal power supply monitor > >On 5/13/2011 9:27 AM, Arjan van de Ven wrote: >> On 5/13/2011 9:19 AM, Mathew, JohnX wrote: >>>> -----Original Message----- >>>> From: Arjan van de Ven [mailto:[email protected]] >>>> Sent: Friday, May 13, 2011 6:49 PM >>>> To: Mathew, JohnX >>>> Cc: [email protected] >>>> Subject: Re: [PATCH] Add support for universal power supply monitor >>>> >>>> On 5/13/2011 7:50 AM, John Mathew wrote: >>>>> This patch enables powertop to display power estimates on >>>>> devices that implement power_supply class and donot have >>>>> acpi battery interface. >>>> I like your code.... one question..... >>>> is there any reason to still use/have the acpi one? >>>> or maybe only probe the acpi code if this one does not find any >sources? >>> Desktops implement the acpi battery interface, but they also support >the power_supply class too. So I think it can be removed. >> and there's feature parity ? >> (if there is... then yeah we should delete the Acpi code) > >(just as background, I'm hesitating putting your patch in without >removing the acpi code, since I don't think having 2 concurrent power >meters is going to work very well.... I'd like to >just go forward with your code only)
For the acpi parameters I see on ubuntu following are the parity features in power_supply ACPI power_suuply present: POWER_SUPPLY_PRESENT capacity state: POWER_SUPPLY_CAPACITY_LEVEL charging state: POWER_SUPPLY_STATUS present rate: POWER_SUPPLY_CURRENT_NOW remaining capacity: POWER_SUPPLY_CAPACITY present voltage: POWER_SUPPLY_VOLTAGE_NOW And the 3 parameters needed by powertop would be POWER_SUPPLY_VOLTAGE_NOW POWER_SUPPLY_CURRENT_NOW POWER_SUPPLY_CAPACITY ACPI driver will by default create sysfs / power_supply interface in later releases than 2.6.37 http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.37.y.git;a=commit;h=1b3d4c3b9a597e216c08bff2c59a8de872ef2d09 Also > > >_______________________________________________ >Power mailing list >[email protected] >https://bughost.org/mailman/listinfo/power --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ Power mailing list [email protected] https://bughost.org/mailman/listinfo/power
