Holger Macht wrote: > On Mon 26. Mar - 20:15:14, Holger Macht wrote: >> On Mon 26. Mar - 18:02:00, Michael Biebl wrote: >>> It seems as if the openSUSE repository [1] ships a version >>> 0.15.10 from the unstable branch of powersave. >>> Would it be possible to release a new 0.15.x version which is officially >>> available from sf.net? >>> I'd like to test the new power management infrastructure >>> (kpowersave-0.7.2 (gui), hal-0.5.9~rc2, pm-utils and >>> powersave-0.15.x(console)) and get them ready for Debian experimental. >> Yes, would be a good idea. I'm even a little bit behind schedule with >> getting a new version into the openSUSE distribution. I'm currently >> removing the remaining bits from the old suspend code and some unneeded >> scripts and will be able to do a release hopefully this evening. > > Ok, because you're the one who actually finds and reports packaging errors > ;-), I've prepared a pre-release [1]. Feel free to report back if it works > for you. I'll publish it tomorrow on sourceforge if nobody objects. >
All in all, the package seems to be in a pretty good shape. After a short review I encountered the following issues/questions: autofoo: 1.) When run with ./configure --enable-docs, you get .. install docs: true docs install dir: NONE/share/doc/packages/powersave .. Attached is the patch docdir.patch, which fixes that (by expanding prefix at make time) 2.) AS_AC_EXPAND: Imo it is wrong to use this macro (e.g. things like make install --prefix=/another/path don't work anymore). Recent versions of autoconf work better without this hack. The attached patch no_as_ac_expand.patch gets rid of AS_AC_EXPAND. unneeded functionality: 3.) Now that we have at least one proper client for the two major desktops (g-p-m and kpowersave), the following files have become obsolete and could/should be removed - do_screen_saver - do_x_notification - wm_logout - wm_shutdown - wttyhx - x_helper_functions - notify (remove zenity references, notify_popup_window) - also the config_files should be updated and references to wm_* should be removed - kde-bin-dir/gnome-bin-dir becomes obsolete if the above files are removed This kind of functionality belongs into the desktop session imho and can be handled much better there. You could leave the files in SVN for hacking experiments, but they shouldn't be distributed in the tarball anymore. documentation: 4.) ChangeLog is incomplete. last entry from October 9. 5.) NEWS is empty. There were quite radical changes architecturally. This should be mentioned in NEWS: new dependencies: liblazy, policykit, pm-utils (as backend for hal) deprecated config files: /etc/powersave/scheme_advanced_powersave /etc/powersave/scheme_presentation /etc/powersave/scheme_acoustic /etc/powersave/sleep /etc/powersave/disk Outline, how the new architecture works, how the different pieces fit together. 6.) documentation - powersaved.8.in still references obsolete powersave schemes (acoustic, presentation) DISABLE_USER_SUSPEND2RAM is not valid anymore, add a note about policykit instead. - README.user_management should contain info about policykit. (I didn't check all doc files. They probably should be revised all of them). 7.) liblazy/policykit checks I don't quite understand, why powersave queries policykit directly. These checks are done a second time within hal in /usr/lib/hal/scripts/hal-system-power-*. Wouldn't it be enough to check the return code of the Suspend()/Hibernate() call? That's all for now. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
=== modified file 'configure.ac'
--- configure.ac 2007-03-26 23:09:36 +0000
+++ configure.ac 2007-03-26 23:11:32 +0000
@@ -68,7 +68,7 @@
AC_ARG_ENABLE(doc-dir, AC_HELP_STRING([--enable-doc-dir=DIR],[Path to where documentation will be installed (also needs --enable-docs flag)]))
if test -z "$enable_doc_dir" ; then
- docdir=${prefix}/share/doc/packages/powersave
+ docdir=\${prefix}/share/doc/packages/powersave
else
docdir="$enable_doc_dir"
fi
=== removed file 'acinclude.m4' --- acinclude.m4 2007-03-26 23:09:36 +0000 +++ acinclude.m4 1970-01-01 00:00:00 +0000 @@ -1,45 +0,0 @@ - -dnl as-ac-expand.m4 0.1.0 -dnl autostars m4 macro for expanding directories using configure's prefix -dnl [EMAIL PROTECTED] - -dnl AS_AC_EXPAND(VAR, CONFIGURE_VAR) -dnl -dnl example -dnl AS_AC_EXPAND(SYSCONFDIR, $sysconfdir) -dnl will set SYSCONFDIR to /usr/local/etc if prefix=/usr/local - -AC_DEFUN(AS_AC_EXPAND, -[ - EXP_VAR=[$1] - FROM_VAR=[$2] - - dnl first expand prefix and exec_prefix if necessary - prefix_save=$prefix - exec_prefix_save=$exec_prefix - - dnl if no prefix given, then use /usr/local, the default prefix - if test "x$prefix" = "xNONE"; then - prefix=$ac_default_prefix - fi - dnl if no exec_prefix given, then use prefix - if test "x$exec_prefix" = "xNONE"; then - exec_prefix=$prefix - fi - - full_var="$FROM_VAR" - dnl loop until it doesn't change anymore - while true; do - new_full_var="`eval echo $full_var`" - if test "x$new_full_var"="x$full_var"; then break; fi - full_var=$new_full_var - done - - dnl clean up - full_var=$new_full_var - AC_SUBST([$1], "$full_var") - - dnl restore prefix and exec_prefix - prefix=$prefix_save - exec_prefix=$exec_prefix_save -]) === modified file 'configure.ac' --- configure.ac 2007-03-26 23:11:32 +0000 +++ configure.ac 2007-03-26 23:26:24 +0000 @@ -119,14 +119,6 @@ GNOME_BINDIR=$withval, GNOME_BINDIR=[/opt/gnome/bin]) -# test if variables are already set -test "x$prefix" = xNONE && prefix=$ac_default_prefix - -AS_AC_EXPAND(sysconfdir, $sysconfdir) -AS_AC_EXPAND(libdir, $libdir) -AS_AC_EXPAND(libexecdir, $libexecdir) -AS_AC_EXPAND(bindir, $bindir) - AC_DEFINE_UNQUOTED(CONFIG_DIR, ["$sysconfdir/powersave"], [directory for configuration files]) AC_DEFINE_UNQUOTED(SCRIPT_DIR, ["$libexecdir/powersave"], [directory for scripts])
signature.asc
Description: OpenPGP digital signature
_______________________________________________ powersave-devel mailing list [email protected] http://forge.novell.com/mailman/listinfo/powersave-devel
