On Tue 27. Mar - 02:08:39, Michael Biebl wrote: > Holger Macht wrote: > > On Mon 26. Mar - 20:15:14, Holger Macht wrote: > >> On Mon 26. Mar - 18:02:00, Michael Biebl wrote: > >>> It seems as if the openSUSE repository [1] ships a version > >>> 0.15.10 from the unstable branch of powersave. > >>> Would it be possible to release a new 0.15.x version which is officially > >>> available from sf.net? > >>> I'd like to test the new power management infrastructure > >>> (kpowersave-0.7.2 (gui), hal-0.5.9~rc2, pm-utils and > >>> powersave-0.15.x(console)) and get them ready for Debian experimental. > >> Yes, would be a good idea. I'm even a little bit behind schedule with > >> getting a new version into the openSUSE distribution. I'm currently > >> removing the remaining bits from the old suspend code and some unneeded > >> scripts and will be able to do a release hopefully this evening. > > > > Ok, because you're the one who actually finds and reports packaging errors > > ;-), I've prepared a pre-release [1]. Feel free to report back if it works > > for you. I'll publish it tomorrow on sourceforge if nobody objects. > > > > All in all, the package seems to be in a pretty good shape. After a > short review I encountered the following issues/questions: > > autofoo: > > 1.) When run with ./configure --enable-docs, you get > .. > install docs: true > docs install dir: NONE/share/doc/packages/powersave > .. > > Attached is the patch docdir.patch, which fixes that (by expanding > prefix at make time)
Applied, thanks. > 2.) AS_AC_EXPAND: Imo it is wrong to use this macro (e.g. things like > make install --prefix=/another/path don't work anymore). Recent versions > of autoconf work better without this hack. The attached patch > no_as_ac_expand.patch gets rid of AS_AC_EXPAND. Applied, thanks. > unneeded functionality: > > 3.) Now that we have at least one proper client for the two major > desktops (g-p-m and kpowersave), the following files have become > obsolete and could/should be removed > - do_screen_saver > - do_x_notification > - wm_logout > - wm_shutdown > - wttyhx > - x_helper_functions > - notify (remove zenity references, notify_popup_window) > - also the config_files should be updated and references to wm_* should > be removed > - kde-bin-dir/gnome-bin-dir becomes obsolete if the above files are removed > > This kind of functionality belongs into the desktop session imho and can > be handled much better there. You could leave the files in SVN for > hacking experiments, but they shouldn't be distributed in the tarball > anymore. Actually you're completely right here. But... I like to keep them for now for users not using KDE or GNOME. I know that keeping them is not the cleanest way, but well, powersaved never has been _that_ clean ;-). It's not completely backed yet how we will handle the things powersaved is doing in the newest version. There's something like open hardware manager coming up (not sure if it's suitable for this). I just like to do something together with all distributions. Actually fedora makes the impression that they like to run gpm with a --no-gui switch. That's cool because you can have a 'make this the system defaults' button in the preferences dialog, but sorry, I don't like to see g-p-m or kpowersave on a server (with all its dependencies) ;-) So as long as not all major distributions are heading in the same direction I think it doesn't hurt to keep those files for now. > documentation: > > 4.) ChangeLog is incomplete. last entry from October 9. Fixed. > 5.) NEWS is empty. > There were quite radical changes architecturally. This should be > mentioned in NEWS: > new dependencies: liblazy, policykit, pm-utils (as backend for hal) > deprecated config files: > /etc/powersave/scheme_advanced_powersave > /etc/powersave/scheme_presentation > /etc/powersave/scheme_acoustic > /etc/powersave/sleep > /etc/powersave/disk > > Outline, how the new architecture works, how the different pieces fit > together. I've added some short sentences, but I don't have enough time at the moment to be more detailed. Feel free to send a patch ;-) > 6.) documentation > - powersaved.8.in still references obsolete powersave schemes (acoustic, > presentation) > DISABLE_USER_SUSPEND2RAM is not valid anymore, add a note about > policykit instead. > > - README.user_management should contain info about policykit. > > (I didn't check all doc files. They probably should be revised all of them). I changed the most critical things some time ago, but not all of course. You're right, most of the documentation has to be revised, I also think that most of it is obsolete. > 7.) liblazy/policykit checks > I don't quite understand, why powersave queries policykit directly. > These checks are done a second time within hal in > /usr/lib/hal/scripts/hal-system-power-*. > Wouldn't it be enough to check the return code of the > Suspend()/Hibernate() call? It's just that the return code of the HAL method is just success or failure, nothing more. So to actually know that "we are not allowed to", we have to do the additional check. > That's all for now. So I'll addressed most of your issues I think. New package is uploaded[1]. Will publish it later today and hopefully without bigger changes. Nobody hinders us from doing a 0.15.12 short after this one. [1] http://www.homac.de/files/powersave-0.15.11.tar.bz2 _______________________________________________ powersave-devel mailing list [email protected] http://forge.novell.com/mailman/listinfo/powersave-devel
