Github user jasobrown commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/184#discussion_r160538757
--- Diff: src/java/org/apache/cassandra/net/MessageOut.java ---
@@ -133,11 +139,13 @@ public MessageOut(InetAddress from,
MessagingService.Verb verb, T payload, IVers
this.parameters = parameters;
}
- public MessageOut<T> withParameter(String key, byte[] value)
+ public <VT> MessageOut<T> withParameter(ParameterType type, VT value)
{
- ImmutableMap.Builder<String, byte[]> builder =
ImmutableMap.builder();
- builder.putAll(parameters).put(key, value);
- return new MessageOut<T>(verb, payload, serializer,
builder.build());
+ List<Object> newParameters = new ArrayList<>(parameters.size() +
3);
--- End diff --
why `+ 3` instead of `+ 2`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
