Github user jasobrown commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/184#discussion_r160491216
  
    --- Diff: src/java/org/apache/cassandra/gms/Gossiper.java ---
    @@ -1112,21 +1131,34 @@ public boolean isSilentShutdownState(EndpointState 
epState)
     
         private static String getGossipStatus(EndpointState epState)
         {
    -        if (epState == null || 
epState.getApplicationState(ApplicationState.STATUS) == null)
    +        if (epState == null)
    +        {
    +            return "";
    +        }
    +
    +        VersionedValue versionedValue = 
epState.getApplicationState(ApplicationState.STATUS_WITH_PORT);
    +        if (versionedValue == null)
    +        {
    +            versionedValue = 
epState.getApplicationState(ApplicationState.STATUS);
    +        }
    +
    +        if (versionedValue == null)
    --- End diff --
    
    maybe move this null check into the block a few lines earlier


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to