Github user jasobrown commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/184#discussion_r160540192
--- Diff: src/java/org/apache/cassandra/net/MessageOut.java ---
@@ -80,12 +81,17 @@
public class MessageOut<T>
{
private static final int SERIALIZED_SIZE_VERSION_UNDEFINED = -1;
+ public static final int PARAMETER_TUPLE_SIZE = 2;
+ public static final int PARAMETER_TUPLE_TYPE_OFFSET = 0;
+ public static final int PARAMETER_TUPLE_PARAMETER_OFFSET = 1;
- public final InetAddress from;
+ public final InetAddressAndPort from;
public final MessagingService.Verb verb;
public final T payload;
public final IVersionedSerializer<T> serializer;
- public final Map<String, byte[]> parameters;
+ //A list of pairs, first object is the ParameterType enum,
--- End diff --
the wording "list of pairs" threw me off as I started thinking "list of
Pair<>s". Not sure I have a better wording off the top of my head, but maybe
modify this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
