Github user jasobrown commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/184#discussion_r162180384
--- Diff: src/java/org/apache/cassandra/gms/ApplicationState.java ---
@@ -19,24 +19,25 @@
public enum ApplicationState
{
- STATUS,
+ @Deprecated STATUS, //Deprecated and unsued in 4.0, stop publishing in
5.0, reclaim in 6.0
LOAD,
SCHEMA,
DC,
RACK,
RELEASE_VERSION,
REMOVAL_COORDINATOR,
- INTERNAL_IP,
- RPC_ADDRESS,
+ @Deprecated INTERNAL_IP, //Deprecated and unused in 4.0, stop
publishing in 5.0, reclaim in 6.0
+ @Deprecated RPC_ADDRESS, // ^ Same
X_11_PADDING, // padding specifically for 1.1
SEVERITY,
NET_VERSION,
HOST_ID,
TOKENS,
RPC_READY,
// pad to allow adding new states to existing cluster
- X1,
- X2,
+ INTERNAL_ADDRESS_AND_PORT, //Replacement for INTERNAL_IP with up to
two ports
+ NATIVE_ADDRESS_AND_PORT, //Replacement for RPC_ADDRESS
--- End diff --
It's unclear to me why you renamed `RPC_ADDRESS` to `NATIVE_ADDRESS`. That
make it really easy to confuse "the addr/port to be used between peers" as
opposed to "the addr/port open for client apps/drivers". Perhaps a better name
is `INTERNODE_ADDRESS_AND_PORT`? (or INTERNAL_ or PEER_ or ...)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
