Github user jasobrown commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/184#discussion_r160490807
  
    --- Diff: src/java/org/apache/cassandra/gms/Gossiper.java ---
    @@ -623,18 +641,19 @@ else if 
(newState.getHeartBeatState().getHeartBeatVersion() != heartbeat)
             }
     
             // do not pass go, do not collect 200 dollars, just gtfo
    +        epState.addApplicationState(ApplicationState.STATUS_WITH_PORT, 
StorageService.instance.valueFactory.left(tokens, computeExpireTime()));
    --- End diff --
    
    is it better to `computeExpireTime()` once and pass the same value into 
each of the `valueFactory` calls?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to