Github user bdeggleston commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r194919778
  
    --- Diff: 
test/long/org/apache/cassandra/locator/DynamicEndpointSnitchLongTest.java ---
    @@ -54,19 +54,19 @@ public void testConcurrency() throws 
InterruptedException, IOException, Configur
                 DynamicEndpointSnitch dsnitch = new DynamicEndpointSnitch(ss, 
String.valueOf(ss.hashCode()));
                 InetAddressAndPort self = 
FBUtilities.getBroadcastAddressAndPort();
     
    -            List<InetAddressAndPort> hosts = new ArrayList<>();
    +            ReplicaList replicas = new ReplicaList();
                 // We want a big list of hosts so  sorting takes time, making 
it much more likely to reproduce the
                 // problem we're looking for.
                 for (int i = 0; i < 100; i++)
                     for (int j = 0; j < 256; j++)
    -                    hosts.add(InetAddressAndPort.getByAddress(new byte[]{ 
127, 0, (byte)i, (byte)j}));
    +                    
replicas.add(Replica.fullStandin(InetAddressAndPort.getByAddress(new byte[]{ 
127, 0, (byte)i, (byte)j})));
    --- End diff --
    
    fixed, the places that need it now deal with SystemReplicas.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to