Github user ifesdjeen commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/224#discussion_r197126256
--- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java ---
@@ -242,11 +249,11 @@ public boolean isSufficientLiveNodes(Keyspace
keyspace, Iterable<InetAddressAndP
}
// Fallthough on purpose for SimpleStrategy
default:
- return Iterables.size(liveEndpoints) >= blockFor(keyspace);
+ return Iterables.size(liveReplicas) >= blockFor(keyspace);
}
}
- public void assureSufficientLiveNodes(Keyspace keyspace,
Iterable<InetAddressAndPort> liveEndpoints) throws UnavailableException
+ public void assureSufficientLiveNodes(Keyspace keyspace,
Iterable<Replica> liveReplicas) throws UnavailableException
--- End diff --
We can use `Replicas` here.
Another question: should there be a distinction between sufficient live
nodes for read and write path? Do we want to make sure there's a sufficient
amount of live full nodes here or later?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
