Github user ifesdjeen commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/224#discussion_r197161771
--- Diff:
test/microbench/org/apache/cassandra/test/microbench/PendingRangesBench.java ---
@@ -97,13 +103,13 @@ public void searchTokenForOldPendingRanges(final
Blackhole bh)
{
int randomToken = ThreadLocalRandom.current().nextInt(maxToken *
10 + 5);
Token searchToken = new
RandomPartitioner.BigIntegerToken(Integer.toString(randomToken));
- Set<InetAddressAndPort> endpoints = new HashSet<>();
- for (Map.Entry<Range<Token>, Collection<InetAddressAndPort>> entry
: oldPendingRanges.asMap().entrySet())
+ Set<Replica> replicas = new HashSet<>();
+ for (Map.Entry<Range<Token>, Collection<Replica>> entry :
oldPendingRanges.asMap().entrySet())
--- End diff --
Since all usages of `asMap` are used with `entrySet`, should we just expose
`entrySet` instead and keep map private?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
