yifan-c commented on a change in pull request #892:
URL: https://github.com/apache/cassandra/pull/892#discussion_r576554260
##########
File path: src/java/org/apache/cassandra/gms/Gossiper.java
##########
@@ -158,38 +158,44 @@
private volatile long lastProcessedMessageAt = System.currentTimeMillis();
- //This property and anything that checks it should be removed in 5.0
- private boolean haveMajorVersion3Nodes = true;
+ // This property and anything that checks it should be removed in 5.0
+ /**
+ * This property is initially set to null version which means that we have
no information about the other nodes.
+ * Once we have information about the cluster, it is set to the earliest
version encountered in the cluster.
+ * Once all nodes are on at least this node version, it becomes null,
which means that we are not upgrading from
+ * the previous version (major, minor).
+ */
+ private CassandraVersion upgradeFromVersion = SystemKeyspace.NULL_VERSION;
- final Supplier<ExpiringMemoizingSupplier.ReturnValue<Boolean>>
haveMajorVersion3NodesSupplier = () ->
+ final Supplier<ExpiringMemoizingSupplier.ReturnValue<CassandraVersion>>
upgradeFromVersionSupplier = () ->
Review comment:
Somehow the comment lost...
One concern about the new supplier is that it is more expensive, since the
prior version has a shortcut to exit early, but the new one has to iterate
through all peers to find the `minVersion`. Should it have a higher chance to
encounter the case that `getReleaseVersion` returns `null` and delay
calculating the `minVersion`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
