jacek-lewandowski commented on a change in pull request #892:
URL: https://github.com/apache/cassandra/pull/892#discussion_r576802515
##########
File path:
test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeReadTest.java
##########
@@ -67,26 +60,24 @@ public void mixedModeReadColumnSubsetDigestCheck() throws
Throwable
if (node != 1)
return; // shouldn't happen but guard for future test changes
+
+ // we need to let gossip settle or the test will fail
+ int attempts = 1;
+ //noinspection Convert2MethodRef
+ while (!((IInvokableInstance) (cluster.get(1))).callOnInstance(()
-> Gossiper.instance.haveMajorVersion3Nodes()))
+ {
+ if (attempts++ > 30)
+ throw new
RuntimeException("Gossiper.instance.isAnyNodeOn30() continually returns false
despite expecting to be true");
+ Thread.sleep(1000);
+ }
+
// should not cause a disgest mismatch in mixed mode
+ logger.info("Testing queries after upgrading - node1: {}, node2:
{}", cluster.get(1).getReleaseVersionString(),
cluster.get(2).getReleaseVersionString());
Review comment:
The purpose of this message was to make it easy to find the time where
the queries started to be executed so I could follow the logs. I can remove
that if you insist
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
