jacek-lewandowski commented on a change in pull request #892:
URL: https://github.com/apache/cassandra/pull/892#discussion_r576929902
##########
File path: src/java/org/apache/cassandra/utils/CassandraVersion.java
##########
@@ -200,6 +200,11 @@ private static Integer tryParseInt(String str)
}
}
+ public boolean isLowerThan(int major, int minor)
Review comment:
Actually, I'd not remove it - the functionality it provides is not
covered by simple version comparison because, for example:
`4.0.0-SNAPSHOT < 4.0.0`
Is there something which can be used as a lower bound for 4.0 family which
does not look confusing?
This mechanism is intended to detect minor version upgrades so we do not
care what is going on in patch, pre-release or build component of the version
because we should not have to change the behaviour of the node in such situation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
